[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

Tue Oct 5 03:09:31 PDT 2021

mgorny added a comment.

In D110997#3041802 <https://reviews.llvm.org/D110997#3041802>, @labath wrote:

> That does not sound unreasonable, though I'm not sure how much is it actually useful. Do you know if its like standard practice when working with serial ports, ttys and stuff?

To be honest, I don't really know. GDB doesn't seem to do it. minicom does restore the initial state.

> TTTT, I'm not very happy that we have _any_ tty code inside the ConnectionFileDescriptorPosix class, so I'm not enthusiastic about expanding it. Let's see how the RFC goes first...

Do you think we should move it somewhere else? With the parameters being configurable via settings, it will probably make sense to move it into gdb-remote anyway.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110997/new/

https://reviews.llvm.org/D110997