[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

Ted Woodward via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 10 14:48:46 PDT 2021


ted created this revision.
ted added a reviewer: clayborg.
ted added a project: LLDB.
Herald added a subscriber: JDevlieghere.
ted requested review of this revision.

The thread that Visual Studio Code displays on a stop is called the focus thread. When the previous focus thread exits and we stop in a new thread, lldb-vscode does not tell vscode to set the new thread as the focus thread, so it selects the first thread in the thread list.

This patch changes lldb-vscode to tell vscode that the new thread is the focus thread. It also includes a test that verifies the DAP stop message for this case contains the correct values.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109633

Files:
  lldb/test/API/tools/lldb-vscode/correct-thread/Makefile
  lldb/test/API/tools/lldb-vscode/correct-thread/TestVSCode_correct_thread.py
  lldb/test/API/tools/lldb-vscode/correct-thread/main.c
  lldb/tools/lldb-vscode/lldb-vscode.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109633.372015.patch
Type: text/x-patch
Size: 5118 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210910/f1ce2d63/attachment.bin>


More information about the lldb-commits mailing list