[Lldb-commits] [PATCH] D109231: [lldb] Improve error handling around GetRngListData()

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.
Herald added a subscriber: JDevlieghere.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:522
+            entry->getContribution(llvm::DW_SECT_RNGLISTS)) {
+      Offset = contribution->Offset;
       return DWARFDataExtractor(data, contribution->Offset,
----------------
If I am reading this correctly, it looks like this will only be set on the non-error case which will leave `contribution_off` in the caller uninitialized in the cases you care about logging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109231/new/

https://reviews.llvm.org/D109231