[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

[Siger Young via Phabricator via lldb-commits]

siger-young added inline comments.


================
Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12
   if (SWIG_FOUND)
-    find_package(Lua 5.3)
+    find_package(Lua 5.3 EXACT REQUIRED)
     if(LUA_FOUND AND SWIG_FOUND)
----------------
mstorsjo wrote:
> This breaks building in setups where SWIG is available, but not Lua. Previously this detected Lua and took it into use if both Lua and SWIG were available, and if not , proceeded without them.
I think removing the "REQUIRED" flags might work. I will revert the broken commit first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108515/new/

https://reviews.llvm.org/D108515