[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added inline comments.


================
Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12
   if (SWIG_FOUND)
-    find_package(Lua 5.3)
+    find_package(Lua 5.3 EXACT REQUIRED)
     if(LUA_FOUND AND SWIG_FOUND)
----------------
mstorsjo wrote:
> This breaks building in setups where SWIG is available, but not Lua. Previously this detected Lua and took it into use if both Lua and SWIG were available, and if not , proceeded without them.
Just removing the `REQUIRED` from here seems to fix my build. Or I could just revert the patch to return to discussing how it should be done.

I'm doing either of them fairly soon in any case, to unbreak my build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108515/new/

https://reviews.llvm.org/D108515