[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 added a comment.

The error that happens in xcodebuild is:

  2021-08-30 16:54:51.925 xcodebuild[95554:469108]  DVTDownloadable: Failed to get authorization with error Error Domain=DVTDownloadableErrors Code=3 "The authorization was denied since no user interaction was possible." UserInfo={AuthorizationErrorCode=-60007, NSLocalizedDescription=The authorization was denied since no user interaction was possible.}
  xcodebuild: error: The authorization was denied since no user interaction was possible.

But I'm not sure what python exception is being thrown (full logs here <https://ci.swift.org/view/LLDB/job/oss-lldb-5.5-incremental-macos-cmake/862/consoleText>). I could add a try/except block around only the check_output call so we don't anything extra, or I could try changing the exception we catch from `subprocess.CalledProcessError` to `subprocess.SubprocessError`, which is the base class of the subprocess exceptions, although I'm not sure if this would fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109004/new/

https://reviews.llvm.org/D109004