[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 31 10:07:19 PDT 2021


teemperor added a comment.
Herald added a subscriber: JDevlieghere.

Do we know what the exception that is being thrown here? FWIW, `except Exception` will catch everything, even completely bogus things such as type errors, calling functions with the wrong arguments and things that should probably be a hard failures instead of marking the test as unsupported (which is completely silent).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109004/new/

https://reviews.llvm.org/D109004



More information about the lldb-commits mailing list