[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

[Kim-Anh Tran via Phabricator via lldb-commits]

kimanh added a comment.

Thanks for having a look at the CL!

In D106355#2893959 <https://reviews.llvm.org/D106355#2893959>, @jankratochvil wrote:

> Is it really just a microoptimization or can you measure any improvement? That `ManualDWARFIndex::Index` will be called is expected. But there should be `m_units_to_avoid` covering all the units so it will quickly return without indexing anything:

Yes, we are aware that it filters out the units that are already indexed by the the name index. In our case we have some third-party libraries that were not built by us, and therefore they don't have any name index. Our main focus, is however, not to debug those third party libraries necessarily, but only our main code that we are compiling. Given that the manual index is taking some time to be generated, we could be lazy about generating it only if we need it.

WDYT?

> Maybe there is rather some other more serious bug to fix (I am aware for example D99850 <https://reviews.llvm.org/D99850> but that would behave differently).

No, there's no serious bug that I'm aware of that is linked to this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106355/new/

https://reviews.llvm.org/D106355