[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

Thu Jul 22 15:41:43 PDT 2021

jankratochvil added a comment.

In D106355#2896117 <https://reviews.llvm.org/D106355#2896117>, @kimanh wrote:

> In our case we have some third-party libraries that were not built by us, and therefore they don't have any name index. Our main focus, is however, not to debug those third party libraries necessarily, but only our main code that we are compiling. Given that the manual index is taking some time to be generated, we could be lazy about generating it only if we need it.

I have a feeling during debugging you will hit the `ManualDWARFIndex::Index` soon during some other access anyway.

One possibility would be to disable loading DWARF for that file. There is `settings set symbols.enable-external-lookup false` (use by `Symbols::LocateExecutableSymbolFile`) but that works only for separate debug info in system directories like `/usr/lib/debug/`.

If you do not want to debug those libraries cannot you just strip debug info from them (`llvm-strip -g`)?

Wouldn't be best to generate `.debug_names` for those 3rd party libraries? GDB has `gdb-add-index` but its `.gdb_index` has not enough information to be useful for LLDB. Still LLDB could generate `.debug_names` out of its internal representation in `ManualDWARFIndex`. That would be useful also for debugging binaries from non-clang compilers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106355/new/

https://reviews.llvm.org/D106355