[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

Is it really just a microoptimization or can you measure any improvement? That `ManualDWARFIndex::Index` will be called is expected. But there should be `m_units_to_avoid` covering all the units so it will quickly return without indexing anything:

  if (units_to_index.empty())
    return;

That is what happens for me on a trivial example `clang -o mainvar mainvar.c -Wall -gdwarf-5 -gpubnames`:

     58  	  if (units_to_index.empty())
  -> 59  	    return;

Maybe there is rather some other more serious bug to fix (I am aware for example D99850 <https://reviews.llvm.org/D99850> but that would behave differently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106355/new/

https://reviews.llvm.org/D106355