[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

We should never assert unless we have to within SB API calls as that takes down the whole debugging session and all this is directly available to users via the script interpreter. I didn't realize we exposed that function via the SB API when I looked at the callers of those functions in D104525 <https://reviews.llvm.org/D104525>, so that's a regression we should fix. I can make a patch for that.

Anyway, this LGTM but please drop the addition of `AppendError` from the SB API. Adding a permanent new function to the SB API requires a bit more review than NFC refactoring. So that's the way to go:

> Or I could just leave the API as is, with SetError calling AppendError internally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104768/new/

https://reviews.llvm.org/D104768