[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

I was going to say we only would need to remove the assert for this one:

  void CommandReturnObject::SetError(const Status &error,
                                     const char *fallback_error_cstr) {

Since SetError checks that the char * is not null in the API layer before calling SetError proper. However, the assert is that the string is not empty. You could pass in a non null ptr, to an empty string. So you're right, those need to be removed.

(I'll update this patch shortly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104768/new/

https://reviews.llvm.org/D104768