[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.
Herald added a subscriber: JDevlieghere.

I'm not totally sure about adding AppendError to the API.

Should we (and where should I) document that AppendError expects a non empty message? On the other hand if you're using a release build the assert to check that isn't a factor, you'll just set eReturnStatusFailed and not add any error text. So it's not going to come up for a lot of users.

Or I could just leave the API as is, with SetError calling AppendError internally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104768/new/

https://reviews.llvm.org/D104768