[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/include/lldb/Target/Trace.h:367
 
+  /// We use 1 as a default stop id for post portem processes.
+  uint32_t m_stop_id = 1;
----------------
clayborg wrote:
> We really shouldn't have to set this manually. Probably best to start it at zero. It might even be better to create a LLDB_INVALID_STOPID define next to the LLDB_INVALID_ADDRESS define and use it. 
this is a pretty good idea


================
Comment at: lldb/source/Target/Trace.cpp:478
+uint32_t Trace::GetStopID() {
+  RefreshLiveProcessState();
+  return m_stop_id;
----------------
clayborg wrote:
> I would just allow the core file to set the process state like any other and start the m_stop_id at zero, the invalid value.
makes sense, i'll do the core file stuff in a different diff 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104422/new/

https://reviews.llvm.org/D104422