[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 17 16:33:51 PDT 2021


wallace updated this revision to Diff 352872.
wallace marked 2 inline comments as done.
wallace added a comment.
Herald added a subscriber: mgorny.

address comments:

- now simply pointing to the last instruction of the trace by default
- removed the GetInstructionSize, as it's really not needed
- made sure that the target lldbCore builds correctly
- improved documentation
- some other small fixes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104422/new/

https://reviews.llvm.org/D104422

Files:
  lldb/include/lldb/Target/Trace.h
  lldb/include/lldb/Target/TraceCursor.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/include/lldb/lldb-forward.h
  lldb/source/Target/CMakeLists.txt
  lldb/source/Target/Trace.cpp
  lldb/source/Target/TraceCursor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104422.352872.patch
Type: text/x-patch
Size: 10718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210617/330e44c1/attachment-0001.bin>


More information about the lldb-commits mailing list