[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

[Peter Collingbourne via Phabricator via lldb-commits]

pcc added a comment.

In D103626#2796554 <https://reviews.llvm.org/D103626#2796554>, @DavidSpickett wrote:

> The side effect here is that you do "memory read <tagged ptr>" and you see untagged addresses for the lines. It's not really that confusing but maybe something we should make a general decision about.
>
> Same thing applies to the previous "memory region" patch.
>
>   (lldb) p ptr1
>   (char *) $1 = 0x344dfffffffffcb0 ""
>   (lldb) memory read ptr1
>   0xfffffffffcb0: f0 05 40 00 00 00 00 00 00 00 00 00 00 00 00 00  .. at .............
>   0xfffffffffcc0: e0 fc ff ff ff ff 00 00 54 f0 e7 f7 ff ff 00 00  ........T.......
>   (lldb) memory region ptr1
>   [0x0000fffffffdf000-0x0001000000000000) rw- [stack]
>
> Personally it doesn't bother me, but then again I know what all the upper bits are doing anyway.

In Android tombstones we display the memory tag inline with the address, e.g.

  memory near x8 ([anon:scudo:primary]):
      00000079fd11a1d0 0000000000000000 0000000000000000  ................
      00000079fd11a1e0 84e4000000020402 000037ecb699a1b3  .............7..
      0f000079fd11a1f0 0000000000000000 0000000000000000  ................
      0f000079fd11a200 0000000000000000 0000000000000000  ................
      00000079fd11a210 0000000000000000 0000000000000000  ................
      00000079fd11a220 0000000000000000 0000000000000000  ................
      00000079fd11a230 0000000000000000 0000000000000000  ................
      00000079fd11a240 0000000000000000 0000000000000000  ................
      00000079fd11a250 0000000000000000 0000000000000000  ................
      00000079fd11a260 0000000000000000 0000000000000000  ................
      00000079fd11a270 0000000000000000 0000000000000000  ................
      00000079fd11a280 0000000000000000 0000000000000000  ................
      00000079fd11a290 0000000000000000 0000000000000000  ................
      00000079fd11a2a0 0000000000000000 0000000000000000  ................
      00000079fd11a2b0 0000000000000000 0000000000000000  ................
      00000079fd11a2c0 0000000000000000 0000000000000000  ................

Maybe this is something worth considering for LLDB memory dumps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103626/new/

https://reviews.llvm.org/D103626