[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid requested changes to this revision.
omjavaid added a comment.
This revision now requires changes to proceed.

This doesnt build ... you need to include #include "lldb/Target/ABI.h" in lldb/source/Commands/CommandObjectMemory.cpp



================
Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:22
+    @skipUnlessPlatform(["linux"])
+    def test_mte_regions(self):
+        if not self.isAArch64PAuth():
----------------
May be consider renaming this test case.


================
Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:23
+    def test_mte_regions(self):
+        if not self.isAArch64PAuth():
+            self.skipTest('Target must support pointer authentication.')
----------------
This condition will always be true because we havent yet connected to remote platform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103626/new/

https://reviews.llvm.org/D103626