[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Since you landed the underlying ABI patch, looking at this again.

Seems like no comments on the BSD side, in which case to be safe we could just have the default `FixWatchpointHitAddress` make no changes. Then remove TBI and PAC for AArch64 Linux, no surprises that way.

Also should the test case include signing the pointer? Though it is a shame to limit it to only systems with PAC, it is part of what we're testing for so I think it should be included.
(I looked at the nop space instructions but they're only for signing instruction pointers)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101361/new/

https://reviews.llvm.org/D101361