[Lldb-commits] [lldb] 80b2da4 - Don't depend on the "run" alias doing shell expanding.

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 15 16:37:55 PDT 2021


Author: Jim Ingham
Date: 2021-06-15T16:37:46-07:00
New Revision: 80b2da42d28466341b9512599aac354c178c39f8

URL: https://github.com/llvm/llvm-project/commit/80b2da42d28466341b9512599aac354c178c39f8
DIFF: https://github.com/llvm/llvm-project/commit/80b2da42d28466341b9512599aac354c178c39f8.diff

LOG: Don't depend on the "run" alias doing shell expanding.
Instead dial it up explicitly.

This test started failing recently and I'm not sure why.  It also
doesn't make sense to me the replacing "run" with "process launch -X 1 --"
should make any difference - run is an alias for the latter.  But
it does pass with the change, and unless we are testing for the exact
run alias, it's better to ask for what we want explicitly.

Added: 
    

Modified: 
    lldb/test/Shell/Host/TestCustomShell.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/Host/TestCustomShell.test b/lldb/test/Shell/Host/TestCustomShell.test
index 1823d094ea7a1..61094ec67bc27 100644
--- a/lldb/test/Shell/Host/TestCustomShell.test
+++ b/lldb/test/Shell/Host/TestCustomShell.test
@@ -6,8 +6,8 @@
 # XFAIL: system-openbsd
 
 # RUN: %clang_host %S/Inputs/simple.c -g -o %t.out
-# RUN: SHELL=bogus not %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s --check-prefix ERROR
-# RUN: env -i %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s
+# RUN: SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 | FileCheck %s --check-prefix ERROR
+# RUN: env -i %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 | FileCheck %s
 
 # ERROR: error: shell expansion failed
 # CHECK-NOT: error: shell expansion failed


        


More information about the lldb-commits mailing list