[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

In D104283#2818693 <https://reviews.llvm.org/D104283#2818693>, @teemperor wrote:

> (Technically that would hide the deleter if the user specifies a default-deleter that just happens to be compatible, but that seems like an obscure corner case so this seems "good enough").

Personally I think if there is the pointer (and `sizeof(std::unique_ptr<XXX, YYY> == 16`) there should be the "deleter =" specified even if it is default deleter. So I rather disagree with your patch. But whetever, it would be nice to finally fix it for the last stable Fedora release.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104283/new/

https://reviews.llvm.org/D104283