[Lldb-commits] [lldb] ca10add - [lldb, win] Remove obsolete workaround for MSVC and python libs

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 10 11:14:36 PDT 2021


Author: Stella Stamenova
Date: 2021-06-10T11:13:38-07:00
New Revision: ca10add5dbe4c3fb2ccaa032d9c7f3e13ca4b14b

URL: https://github.com/llvm/llvm-project/commit/ca10add5dbe4c3fb2ccaa032d9c7f3e13ca4b14b
DIFF: https://github.com/llvm/llvm-project/commit/ca10add5dbe4c3fb2ccaa032d9c7f3e13ca4b14b.diff

LOG: [lldb, win] Remove obsolete workaround for MSVC and python libs

This workaround was necessary before the major changes of managing python versions, but it is not needed anymore.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D104047

Added: 
    

Modified: 
    lldb/source/API/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt
index a7d6592b31dc0..b74bfd4a2ff8d 100644
--- a/lldb/source/API/CMakeLists.txt
+++ b/lldb/source/API/CMakeLists.txt
@@ -182,13 +182,7 @@ if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
   set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
 endif()
 
-if (MSVC)
-  # Only MSVC has the ABI compatibility problem and avoids using FindPythonLibs,
-  # so only it needs to explicitly link against ${Python3_LIBRARIES}
-  if (LLDB_ENABLE_PYTHON)
-    target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES})
-  endif()
-else()
+if (NOT MSVC)
   set_target_properties(liblldb
     PROPERTIES
     OUTPUT_NAME lldb


        


More information about the lldb-commits mailing list