[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 10 11:14:36 PDT 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rGca10add5dbe4: [lldb, win] Remove obsolete workaround for MSVC and python libs (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104047/new/

https://reviews.llvm.org/D104047

Files:
  lldb/source/API/CMakeLists.txt


Index: lldb/source/API/CMakeLists.txt
===================================================================
--- lldb/source/API/CMakeLists.txt
+++ lldb/source/API/CMakeLists.txt
@@ -182,13 +182,7 @@
   set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
 endif()
 
-if (MSVC)
-  # Only MSVC has the ABI compatibility problem and avoids using FindPythonLibs,
-  # so only it needs to explicitly link against ${Python3_LIBRARIES}
-  if (LLDB_ENABLE_PYTHON)
-    target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES})
-  endif()
-else()
+if (NOT MSVC)
   set_target_properties(liblldb
     PROPERTIES
     OUTPUT_NAME lldb


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104047.351223.patch
Type: text/x-patch
Size: 640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210610/744a9368/attachment.bin>


More information about the lldb-commits mailing list