[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy run. I got bored of writing 'format' everywhere so I translated every comment into a different language via Google translate. I'll already accept this as this is easy to fix.



================
Comment at: lldb/include/lldb/Expression/ExpressionParser.h:45
+  virtual ~ExpressionParser() = default;
+  ;
 
----------------
Please drop that when you land it.


================
Comment at: lldb/include/lldb/Target/Process.h:227
 
-  {}
+      = default;
 
----------------
format


================
Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:41
+  virtual ~RecognizedStackFrame() = default;
+  ;
 
----------------
please remove that pointy boy


================
Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:68
+  virtual ~StackFrameRecognizer() = default;
+  ;
 };
----------------
and that one too


================
Comment at: lldb/source/Interpreter/OptionValueFileColonLine.cpp:26
 
-{}
+    = default;
 
----------------
formaat


================
Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h:219
 
-    {}
+        = default;
 
----------------
formato


================
Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h:111
 
-    {}
+        = default;
 
----------------
formatione


================
Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h:50
+  RSCoordinate() = default;
+  ;
 
----------------
goodbye


================
Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h:60
 
-    {}
+        = default;
   };
----------------
フォーマット


================
Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h:57
 
-    {}
+        = default;
   };
----------------
хэлбэр хэмжээ


================
Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h:195
 
-    {}
+        = default;
 
----------------
formoup


================
Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h:219
 
-    {}
+        = default;
 
----------------
isimo


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104041/new/

https://reviews.llvm.org/D104041