[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 9 08:23:04 PDT 2021
teemperor accepted this revision.
teemperor added a comment.
This doesn't compile for me (on Linux):
In file included from /home/teemperor/work/ci/llvm-project/lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp:11:
In file included from /home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h:15:
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h:96:14: error: use of undeclared identifier 'nil'
id m_dev = nil;
^
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h:132:14: error: use of undeclared identifier 'nil'
id m_dev = nil;
^
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h:172:14: error: use of undeclared identifier 'nil'
id m_dev = nil;
^
The `nil` is some Obj-C thing but the headers are includes from a C++ file. I don't think we should add Obj-C includes to the header as we really need to keep the Objective-C++ code in LLDB as small as possible, so maybe change this to `nullptr`?
Beside that I couldn't find anything that would block this patch. There are a bunch of additional NFC cleanups possible but that seems out of scope, so LGTM modulo `nil -> nullptr`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103483/new/
https://reviews.llvm.org/D103483
More information about the lldb-commits
mailing list