[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 7 14:43:05 PDT 2021


teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Some small rename I forgot to point out, but LGTM modulo that rename. Thanks for cleaning this up!



================
Comment at: lldb/include/lldb/Symbol/Symtab.h:186
 private:
+  UniqueCStringMap<uint32_t> &GetFunctypeMap(lldb::FunctionNameType type) {
+    auto map = m_name_to_symbol_indices.find(type);
----------------
`GetNameToSymbolIndexMap` might be more accurate now (I should have pointed out when changing the variable name).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103652/new/

https://reviews.llvm.org/D103652



More information about the lldb-commits mailing list