[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 26 15:02:39 PDT 2021


bulbazord created this revision.
bulbazord added a reviewer: teemperor.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

There are several instances where one may want to ask questions about
the name of a method/function/whatever. Classes like
CPlusPlusLanguage::MethodName and ObjCLanguage::MethodName fulfill this
purpose right now, but users of these have to have knowledge on these
classes (from plugins) to function. I propose a new class
`Language::MethodNameInfo` to abstract this away so that lldb's Core
libraries can ask questions about a method name without knowing the
details of a plugin.

Currently the class only has one method to override, `GetSelector`, but
I imagine it will have more in the future. I only added the one method
needed to replace the use of `ObjCLanguage` in Symtab.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103210

Files:
  lldb/include/lldb/Target/Language.h
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.h
  lldb/source/Symbol/Symtab.cpp
  lldb/source/Target/Language.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103210.348105.patch
Type: text/x-patch
Size: 4906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210526/dcc4c947/attachment.bin>


More information about the lldb-commits mailing list