[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text
Abhina Sree via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 30 10:39:20 PDT 2021
abhina.sreeskantharajan marked 2 inline comments as done.
abhina.sreeskantharajan added inline comments.
Comment at: llvm/include/llvm/Support/FileSystem.h:757
+ /// OF_TextWithCRLF = OF_Text | OF_CRLF
+ OF_TextWithCRLF = 3,
> Nit: If it were me, I'd put the `OF_Text | OF_CRLF` directly in the code (in place of the `3`) instead of in the comment.
Thanks, your solution will also prevent future errors if there is any renumbering
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits