[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I think this looks fine. Could you also create a gdb-client test case (you can ignore the default thread thingy)?



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1131
 
 bool GDBRemoteCommunicationClient::GetDefaultThreadId(lldb::tid_t &tid) {
   StringExtractorGDBRemote response;
----------------
It looks like this is only used in the (probably completely broken) non-stop mode. I should put that on my to-delete list...


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:370
+  void GetCurrentProcessAndThreadIDs(
+      std::vector<std::pair<lldb::pid_t, lldb::tid_t>> &ids,
+      bool &sequence_mutex_unavailable);
----------------
lets make this an actual return value


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99603/new/

https://reviews.llvm.org/D99603