[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

Tue Mar 30 08:13:23 PDT 2021

mgorny added a comment.

In D98822#2658443 <https://reviews.llvm.org/D98822#2658443>, @labath wrote:

> Yeah, but then we have to maintain two copies of breakpoint-unsetting code in perpetuity.  Given that we've managed to come this far with this being completely broken, I think we can wait a little longer until the client support is in place.

Ok, I guess I can do that.

What about debug registers on FreeBSD? This system is pretty unique because child processes inherit dbregs from parent, and therefore we need to clear them. GDB doesn't do that and watchpoints crash forked children. Should we keep the clearing part as a hack specific to FreeBSD, or have lldb generic clear all hardware breakpoints and watchpoints on fork? Independently of that, I'm going to file a bug for FreeBSD to see if this is really the intended behavior.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98822/new/

https://reviews.llvm.org/D98822