[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

LGTM.

Regarding the LLDB example: Given that the LLDB API is in theory not bound to the semantics a specific language, I think one can argue that `IsAnonymousType` could also return true for unnamed classes. The use case that triggered this whole discussion was someone who wanted to know whether the type has a name, so calling this function seems logical. Given that we don't really have a valid type name for unnamed classes, we might want to change the implementation of `IsAnonymousType` to also return true for unnamed classes. But all that is out of scope for this patch which is about fixing the type printer in Clang. Just bringing this up as it's the example in the patch description.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96807/new/

https://reviews.llvm.org/D96807