[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

Aaron Ballman via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 16 13:04:49 PST 2021


aaron.ballman added a comment.

Thank you for working on this! In general, I like the change.



================
Comment at: clang/lib/AST/TypePrinter.cpp:1308
+    } else if ((isa<RecordDecl>(D) && cast<RecordDecl>(D)->isAnonymousStructOrUnion()) ||
+        isa<EnumDecl>(D)) {
       OS << "anonymous";
----------------
I think `EnumDecl` should probably be `unnamed` rather than `anonymous` because there's no term of art for an anonymous enumeration (there's only anonymous structures and anonymous unions). WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96807/new/

https://reviews.llvm.org/D96807



More information about the lldb-commits mailing list