[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/test/API/CMakeLists.txt:59
 set(LLDB_TEST_COMPILER "${LLDB_DEFAULT_TEST_COMPILER}" CACHE PATH "C Compiler to use for building LLDB test inferiors")
-set(LLDB_TEST_DSYMUTIL "${LLDB_DEFAULT_TEST_DSYMUTIL}" CACHE PATH "dsymutil used for generating dSYM bundles")
-set(LLDB_TEST_FILECHECK "${LLDB_DEFAULT_TEST_FILECHECK}" CACHE PATH "FileCheck used for testing purposes")
----------------
labath wrote:
> Dsymutil is in compilation of inferiors, so it may make sense to leave it individually configurable, like we have it for the compiler, but I don't know if that would actually be useful (?)
Yeah, I recently did some work to make it possible to run the test suite against an Xcode installation, which contains a `dsymutil` but no `FileCheck` or `yaml2obj`. To keep that working, I need a way to configure the latter two separately. To me it doesn't really matter whether that's by setting the tools dir and having dsymutil specified separately, but that one way this would continue working. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95261/new/

https://reviews.llvm.org/D95261