[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 22 12:57:08 PST 2021


labath added a comment.

I should add, this also ensures one does not need to introduce a similar amount of cruft for each new llvm tool that he wants to use in the tests.



================
Comment at: lldb/test/API/CMakeLists.txt:59
 set(LLDB_TEST_COMPILER "${LLDB_DEFAULT_TEST_COMPILER}" CACHE PATH "C Compiler to use for building LLDB test inferiors")
-set(LLDB_TEST_DSYMUTIL "${LLDB_DEFAULT_TEST_DSYMUTIL}" CACHE PATH "dsymutil used for generating dSYM bundles")
-set(LLDB_TEST_FILECHECK "${LLDB_DEFAULT_TEST_FILECHECK}" CACHE PATH "FileCheck used for testing purposes")
----------------
Dsymutil is in compilation of inferiors, so it may make sense to leave it individually configurable, like we have it for the compiler, but I don't know if that would actually be useful (?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95261/new/

https://reviews.llvm.org/D95261



More information about the lldb-commits mailing list