[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

Fri Jan 22 05:09:14 PST 2021

augusto2112 added a comment.

@labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the `terminalHasColors` function in the `Process.inc` file (I really should've tried that before). I'm currently recompiling and will re-run the tests locally, and will push the changes after that. I do worry this could potentially impact macOS though (I don't know if these low-level terminal functions work differently between differently OSes), so how do we ensure this doesn't break anything there?

Also, since the patch will be completely different, should I open a new patch or push to this one and just change the title/description accordingly?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95165/new/

https://reviews.llvm.org/D95165