[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 22 04:15:15 PST 2021


labath added a comment.

Can you be more specific about what is the nature and cause of this breakage?

Could it maybe be the fact that the `set_curterm(nullptr)` call (inside `terminalHasColors(fd)`) leaves terminfo with no "current" terminal, (whereas before the call it contained the "current" terminal, as setup by libedit? If so then maybe the right fix is to change `terminalHasColors` to restore the current terminal to whatever it was at the start of the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95165/new/

https://reviews.llvm.org/D95165



More information about the lldb-commits mailing list