[Lldb-commits] [PATCH] D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 22 08:55:21 PST 2020


JDevlieghere added a comment.

In D93663#2467370 <https://reviews.llvm.org/D93663#2467370>, @labath wrote:

> You can't put these declarations inside `do {} while(0)` -- the additional scope works against us in this case, and forces a premature timer termination. Other than that, this seems fine...

Wow, I totally did that on autopilot 🤡


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93663/new/

https://reviews.llvm.org/D93663



More information about the lldb-commits mailing list