[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 11 00:47:48 PST 2020
mgorny added a comment.
In D91216#2387909 <https://reviews.llvm.org/D91216#2387909>, @labath wrote:
> Regarding the asserts, I'm thinking if it wouldn't be better to check the compare the resulting RegisterInfo structs instead of the raw struct layout. The reasons for that are:
> - it will be checking the thing that we're actually relying on (the register info macros is pretty complex and can be messed up easily
> - the register info artifacts (unlike the GPR structs) are exported from these files, so the checks for that could be placed into a unit test
> What do you think?
I presume you mean verifying that `byte_offset`s and `byte_size`s are written correctly to the struct? I suppose that makes sense.
I like the idea that static asserts are going to blow up during compilation already but I suppose it's not very important as I don't expect these structures to change.
CHANGES SINCE LAST ACTION
More information about the lldb-commits