[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 11 00:27:02 PST 2020
labath added a comment.
Regarding the asserts, I'm thinking if it wouldn't be better to check the compare the resulting RegisterInfo structs instead of the raw struct layout. The reasons for that are:
- it will be checking the thing that we're actually relying on (the register info macros is pretty complex and can be messed up easily
- the register info artifacts (unlike the GPR structs) are exported from these files, so the checks for that could be placed into a unit test
What do you think?
CHANGES SINCE LAST ACTION
More information about the lldb-commits