[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 7 11:49:27 PDT 2020


labath added a comment.

I really want to avoid having language specific strings in the tests. Skipping tests which depend on these is a reasonable approach (as you've discovered, there shouldn't be that many of them -- it's really just the tests which check that we actually can retrieve the error from the OS), and it could be later improved by switching to an english locale on a best-effort basis (i.e., if the locale is available).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88975/new/

https://reviews.llvm.org/D88975



More information about the lldb-commits mailing list