[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

[Alexandre Ganea via Phabricator via lldb-commits]

aganea added a comment.

In D88975#2317494 <https://reviews.llvm.org/D88975#2317494>, @amccarth wrote:

> Maybe dotest.py could change its own Windows locale setting and the processes it spawns would inherit that.  I don't know if that would work, but I don't see a good alternative.

One problem is that some users might //not// have the English language pack installed. I only have `fr-CA` and `en-CA` installed but not `en-US`. There's absolutely no guarantee that there will be a `en-XX` package available. I'll do some more testing and upload a new diff, but I took a defensive approach, like for `StatusTest.cpp`, where the two tests below in `TestTargetCommand.py` would only run if `en-US` is the current locale. Maybe afterwards, in a subsequent patch, we could add more code to temporarily switch to `en-US` locale if it's available?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88975/new/

https://reviews.llvm.org/D88975