[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:83
+
+    AttributeValue(const DWARFUnit *_cu, dw_offset_t _die_offset,
+                   dw_attr_t _attr, dw_form_t _form)
----------------
aprantl wrote:
> We usually don't prefix constructor arguments. Most LLDB code would write this as 
> m_cu(cu) for classes and cu(cu) for structs.
Why not drop the prefixes all together? I don't see what they add here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87441/new/

https://reviews.llvm.org/D87441