[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 11 08:22:22 PDT 2020


aprantl added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:83
+
+    AttributeValue(const DWARFUnit *_cu, dw_offset_t _die_offset,
+                   dw_attr_t _attr, dw_form_t _form)
----------------
We usually don't prefix constructor arguments. Most LLDB code would write this as 
m_cu(cu) for classes and cu(cu) for structs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87441/new/

https://reviews.llvm.org/D87441



More information about the lldb-commits mailing list