[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Aug 12 14:50:03 PDT 2020
teemperor added a comment.
I'll leave the test review to Pavel who knows that much better, but I have two last nits about the test.
================
Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:59
+#
+# 86dea1f39bd127776b999e10dff212003068d30a
+#
----------------
I think this was still generated with system clang. info_string below says this was compiled by `Apple clang version 12.0.0 (clang-1200.0.31.1)` and not the listed commit (which would create an info_string like `clang version 12.0.0 (https://github.com/llvm/llvm-project 86dea1f39bd127776b999e10dff212003068d30a)`.)
================
Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:149
+ .asciz "MacOSX10.15.sdk" ## string offset=117
+ .asciz "/Users/friss/dev/stash/xnu" ## string offset=133
+ .asciz "ug" ## string offset=160
----------------
You can avoid these system-specific paths by compiling the file in /tmp with your cwd in /tmp and passing `-isysroot /` to the clang invocation. This way this section would look like this for everyone independently of their system username or macOS version (which will make updating this much easier):
```
lang=python
.asciz "clang version 12.0.0 (https://github.com/llvm/llvm-project 6acb897dfbc0ec22007cde50b3bc9c60f4674fb2)" ## string offset=0
.asciz "/tmp/weird.c" ## string offset=101
.asciz "/" ## string offset=114
.asciz "/tmp" ## string offset=116
.asciz "ug" ## string offset=121
.asciz "U" ## string offset=124
.asciz "raw" ## string offset=126
.asciz "unsigned int" ## string offset=130
.asciz "a" ## string offset=143
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85376/new/
https://reviews.llvm.org/D85376
More information about the lldb-commits
mailing list