[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 11 03:32:11 PDT 2020


labath added a comment.

Sorry about the delay, I was OOO.

I think that making these consistent with the DWARF spec is a good idea. It's true that this makes `DebugAbbrevOffset` a bit longish. I could also live with just `AbbrevOffset`, but I think the longer version is also fine for two reasons:

- I expect most of this stuff to be created by copy-pasting
- Ideally, I would want to avoid explicitly specifying this field in most cases, and instead rely on some sort of symbolic references between the sections (as discussed in the other reviews)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85289/new/

https://reviews.llvm.org/D85289



More information about the lldb-commits mailing list