[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

Mon Aug 10 10:30:56 PDT 2020

JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.

I applied the patch locally and gave this another shot. I'm still missing all the common ways I accept auto-suggestions in fish:

- C-e
- Right arrow
- End

but I'm fine with fixing that in another patch assuming that wouldn't require a huge redesign. BTW your original description says you can accept suggestions with C-k, but it's actually C-f.

My terminal isn't honoring the faint escape code, it would be nice to make this configurable like most of the other color options.

As I mentioned in my earlier comment you can't enable auto-suggestions in the current command interpreter. You have to launch with `-o settings set show-autosuggestion true` or adding it to your `.lldbinit. I think that's fine but I'd be nice if we could fix that.

All these things can be fixed in follow-up patches. I already have a hard time following the discussion here so I'm fine with landing this and improving things incrementally.

================
Comment at: lldb/test/API/iohandler/autosuggestion/TestAutosuggestion.py:107
+    
\ No newline at end of file

----------------
No newline at end of file

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81001/new/

https://reviews.llvm.org/D81001