[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Target/TargetList.cpp:245
           }
+          error_strm.Printf("), specify an architecture to disambiguate");
+          error.SetErrorString(error_strm.GetString());
----------------
jingham wrote:
> jingham wrote:
> > I'm not sure why you removed mention of --platform from this error because with this patch it should now be possible to disambiguate either by specifying  --platform or --arch, right?
> Ah, okay I didn't see that the platform doesn't get used everywhere in this patch.
Another reason is that this is generic code, it shouldn't mention command interpreter options. You could've called in here trough the SB API as well. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84809/new/

https://reviews.llvm.org/D84809