[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 29 04:09:04 PDT 2020
labath added a comment.
The changes don't seem contentious to me, though I am also not very familiar with this code.
What surprised me was the `OptionGroupPlatform` argument to `TargetList::CreateTargetInternal`. It seems like a slighly unusual thing to have, as that means the equivalent SB call would have to construct an OptionGroup object even though it has nothing to do with CLI. But that is not a problem caused by this patch...
CHANGES SINCE LAST ACTION
More information about the lldb-commits