[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 28 17:03:00 PDT 2020
jingham added inline comments.
Comment at: lldb/source/Target/TargetList.cpp:245
+ error_strm.Printf("), specify an architecture to disambiguate");
> I'm not sure why you removed mention of --platform from this error because with this patch it should now be possible to disambiguate either by specifying --platform or --arch, right?
Ah, okay I didn't see that the platform doesn't get used everywhere in this patch.
Comment at: lldb/test/API/commands/target/basic/bogus.yaml:945
+ Values: 
+ - Length: 39
> You don't use the debug info, might as well leave it out.
CHANGES SINCE LAST ACTION
More information about the lldb-commits