[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Thanks for fixing this.



================
Comment at: lldb/source/Core/ValueObject.cpp:690
 
-  if (!valobj && synthetic_array_member)
-    valobj = GetSyntheticValue()
-                 ->GetChildAtIndex(synthetic_index, synthetic_array_member)
-                 .get();
+  // In case of an incomplete type, LLDB will try to use the ValueObject's
+  // synthetic value to create the child ValueObject.
----------------
Sorry for the pedantry, but the wording "LLDB will try to ..." makes me think that there is some other part of lldb which "tries to use the synthetic value", and this code is somehow responding to that behavior.
But IIUC, this *is* the code which is using the synthetic value. In that case, it would be enough to say "In case of an incomplete type, **try to use** the synthetic value to ...".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83327/new/

https://reviews.llvm.org/D83327