[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D81499#2086268 <https://reviews.llvm.org/D81499#2086268>, @jingham wrote:

> This looks okay to me though I'm not very familiar with the llvm file system interfaces.
>
> Do we have any tests that tests that log output gets emitted to the file requested when you do "log enable -f somefile whatever"?  If so and they still work, LGTM.  If we don't test that at all, we should probably add a test on the principle of "when you monkey with something that doesn't have a test, you should add one..."


Yep, we had two tests that were screaming at me when I messed up :-)


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81499/new/

https://reviews.llvm.org/D81499